Code Review for pcid

Prepared by: (alex.wilson) on 2018-Feb-23 02:13 +0000 UTC
Workspace:/home/alex.wilson/smartos-live/projects/illumos (explicit head at 8505065c439d)
Compare against: previous revision (at 50903546a125)
Summary of changes: 946 lines changed: 559 ins; 233 del; 154 mod; 40398 unchg
Patch of changes: pcid.patch
Printable review: pcid.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/i86pc/modules/unix/unix.c

OS-6546 Use PCID if KPTI is enabled
5 lines changed: 0 ins; 0 del; 5 mod; 1022 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/io/gfx_private/gfxp_vm.c

OS-6546 Use PCID if KPTI is enabled
2 lines changed: 0 ins; 0 del; 2 mod; 394 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/fb_swtch_src.s

OS-6546 Use PCID if KPTI is enabled
5 lines changed: 5 ins; 0 del; 0 mod; 450 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/kpti_trampolines.s

OS-6546 Use PCID if KPTI is enabled
35 lines changed: 35 ins; 0 del; 0 mod; 714 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/ml/mpcore.s

OS-6546 Use PCID if KPTI is enabled
2 lines changed: 0 ins; 0 del; 2 mod; 637 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/cpuid.c

OS-6546 Use PCID if KPTI is enabled
36 lines changed: 34 ins; 0 del; 2 mod; 5210 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/fakebop.c

OS-6546 Use PCID if KPTI is enabled
6 lines changed: 6 ins; 0 del; 0 mod; 2799 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mach_kdi.c

OS-6546 Use PCID if KPTI is enabled
6 lines changed: 0 ins; 6 del; 0 mod; 204 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mlsetup.c

OS-6546 Use PCID if KPTI is enabled
6 lines changed: 6 ins; 0 del; 0 mod; 535 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_pc.c

OS-6546 Use PCID if KPTI is enabled
12 lines changed: 1 ins; 4 del; 7 mod; 696 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/mp_startup.c

OS-6546 Use PCID if KPTI is enabled
2 lines changed: 2 ins; 0 del; 0 mod; 2109 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/os/startup.c

OS-6546 Use PCID if KPTI is enabled
6 lines changed: 6 ins; 0 del; 0 mod; 3396 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/mach_mmu.h

OS-6546 Use PCID if KPTI is enabled
17 lines changed: 13 ins; 4 del; 0 mod; 169 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/sys/pc_mmu.h

OS-6546 Use PCID if KPTI is enabled
9 lines changed: 7 ins; 0 del; 2 mod; 64 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/hat_i86.c

OS-6546 Use PCID if KPTI is enabled
267 lines changed: 102 ins; 78 del; 87 mod; 4989 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/hat_i86.h

OS-6546 Use PCID if KPTI is enabled
48 lines changed: 30 ins; 13 del; 5 mod; 295 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/hat_kdi.c

OS-6546 Use PCID if KPTI is enabled
16 lines changed: 13 ins; 0 del; 3 mod; 338 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/hat_pte.h

OS-6546 Use PCID if KPTI is enabled
3 lines changed: 1 ins; 0 del; 2 mod; 309 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/htable.c

OS-6546 Use PCID if KPTI is enabled
10 lines changed: 5 ins; 0 del; 5 mod; 2514 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/htable.h

OS-6546 Use PCID if KPTI is enabled
1 line changed: 0 ins; 1 del; 0 mod; 349 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/i86_mmu.c

OS-6546 Use PCID if KPTI is enabled
276 lines changed: 170 ins; 101 del; 5 mod; 413 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/kboot_mmu.c

OS-6546 Use PCID if KPTI is enabled
6 lines changed: 0 ins; 0 del; 6 mod; 512 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86pc/vm/vm_machdep.c

OS-6546 Use PCID if KPTI is enabled
86 lines changed: 85 ins; 0 del; 1 mod; 4021 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/i86xpv/os/xpv_panic.c

OS-6546 Use PCID if KPTI is enabled
1 line changed: 0 ins; 0 del; 1 mod; 1029 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/asm/htable.h

OS-6546 Use PCID if KPTI is enabled
13 lines changed: 0 ins; 13 del; 0 mod; 90 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/asm/mmu.h

OS-6546 Use PCID if KPTI is enabled
41 lines changed: 24 ins; 8 del; 9 mod; 85 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/ml/i86_subr.s

OS-6546 Use PCID if KPTI is enabled
5 lines changed: 0 ins; 0 del; 5 mod; 4410 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/ia32/os/desctbls.c

OS-6546 Use PCID if KPTI is enabled
3 lines changed: 0 ins; 3 del; 0 mod; 1474 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/controlregs.h

OS-6546 Use PCID if KPTI is enabled
11 lines changed: 6 ins; 2 del; 3 mod; 239 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/uts/intel/sys/x86_archext.h

OS-6546 Use PCID if KPTI is enabled
10 lines changed: 8 ins; 0 del; 2 mod; 932 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.